Remove ReplicaSet informer #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariomac
requested review from
grcevski,
marctc and
rafaelroquetto
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1204 +/- ##
==========================================
+ Coverage 73.29% 82.06% +8.77%
==========================================
Files 135 136 +1
Lines 11549 11420 -129
==========================================
+ Hits 8465 9372 +907
+ Misses 2427 1514 -913
+ Partials 657 534 -123
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
grcevski
approved these changes
Sep 27, 2024
docs/sources/configure/options.md
Outdated
| @@ -662,6 +662,25 @@ establish communication with the Kubernetes Cluster. | |||
|
|
|||
| Usually you won't need to change this value. | |||
|
|
|||
| | YAML | Environment variable | Type | Default | | |||
| |---------------------|--------------------------------|--------|------------------| | |||
| | `disable_informers` | `BEYLA_KUBE_DISABLE_INFORMERS` | string | `~/.kube/config` | | |||
There was a problem hiding this comment.
I think the default here is a copy paste mistake, probably should be empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #1202, closes first item of #1198
The ReplicaSet informer was only needed to get the name of the owning Deployment. As long as that deployment name is already part of the ReplicaSet informer, we don't actually need to make use of the Kube API for that.
This PR removes all the code related to ReplicaSet informers.