Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cog to generate Go and TS types #485

Merged
merged 7 commits into from
Nov 23, 2024
Merged

Use cog to generate Go and TS types #485

merged 7 commits into from
Nov 23, 2024

Conversation

K-Phoen
Copy link
Member

@K-Phoen K-Phoen commented Nov 19, 2024

Replaces #296

This PR replaces cuetsy and deepmap/oapi-codegen to generate Go and TS types.

Note: the code by cog can be different from what is currently generated, I'd need some help to review these changes and determine if they are correct/acceptable.
I followed the issue tracker tutorial and the results seem to make sense to me but I'm far from being an expert 😅

Copy link
Contributor

@IfSentient IfSentient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, sorry that it took a while for me to finish reviewing it. I think there are a few conflicts in go.mod/go.sum because of dependabot, but once those are resolved I think this is good to merge. Thank you!

@K-Phoen
Copy link
Member Author

K-Phoen commented Nov 22, 2024

Rebased, everything still looks green :)

@IfSentient IfSentient merged commit 2b5eb53 into main Nov 23, 2024
9 checks passed
@IfSentient IfSentient deleted the codegen/cog branch November 23, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants