Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix links broken by plugin-tools site reorg #343

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

josmperez
Copy link
Contributor

@josmperez josmperez commented Jul 12, 2024

Fix links broken by plugin-tools site reorg.

@josmperez josmperez requested review from a team as code owners July 12, 2024 21:23
@josmperez josmperez requested review from jackw, wbrowne, andresmgot, oshirohugo and sympatheticmoose and removed request for a team July 12, 2024 21:23
Copy link
Contributor

@sympatheticmoose sympatheticmoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of these changes should be resolved by running create-plugin update which is done periodically. Given we have redirects in place I would prefer to wait until that has run then catch any remaining links rather than have to review 82 files 😅

@josmperez
Copy link
Contributor Author

A lot of these changes should be resolved by running create-plugin update which is done periodically. Given we have redirects in place I would prefer to wait until that has run then catch any remaining links rather than have to review 82 files 😅

Sounds good. Let's wait a bit.

@academo
Copy link
Member

academo commented Jul 15, 2024

@josmperez
I am curious to know if we didn't setup a redirect for https://grafana.com/developers/plugin-tools/create-a-plugin/extend-a-plugin/extend-configurations#extend-the-eslint-config

because many projects have these files with this links and people might follow them if they open those files and haven't run update (which is not very often)

@sympatheticmoose
Copy link
Contributor

@academo there's a redirect in the re-org PR https://github.com/grafana/plugin-tools/pull/993/files#diff-d8d70f81bb443af1e4aa5f4b0ce4ba1cc15800b67be29a2bcc66187fb3c10d5cR193-R194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🧑‍💻 In development
Development

Successfully merging this pull request may close these issues.

3 participants