Update reconcile->finish naming, inline with create and start

grafana · Feb 11, 2022 · 46fb8e3 · 46fb8e3
1 parent 350ca49
commit 46fb8e3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/controllers/k6_controller.go b/controllers/k6_controller.go
@@ -62,7 +62,7 @@ func (r *K6Reconciler) Reconcile(req ctrl.Request) (ctrl.Result, error) {
 	case "created":
 		return StartJobs(ctx, log, k6, r)
 	case "started":
-		return ReconcileJobs(ctx, log, k6, r)
+		return FinishJobs(ctx, log, k6, r)
 	case "finished":
 		// delete if configured
 		if k6.Spec.Cleanup == "post" {

diff --git a/controllers/k6_reconcile.go → controllers/k6_finish.go b/controllers/k6_reconcile.go → controllers/k6_finish.go
@@ -12,8 +12,8 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/client"
 )
 
-// Reconcile k6 status with job status
-func ReconcileJobs(ctx context.Context, log logr.Logger, k6 *v1alpha1.K6, r *K6Reconciler) (ctrl.Result, error) {
+// Mark k6 as finished as jobs finish
+func FinishJobs(ctx context.Context, log logr.Logger, k6 *v1alpha1.K6, r *K6Reconciler) (ctrl.Result, error) {
 	selector := labels.SelectorFromSet(map[string]string{
 		"app":   "k6",
 		"k6_cr": k6.Name,