Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(godeltaprof): optionally emmit generics types #70

Merged
merged 5 commits into from
Nov 24, 2023
Merged

fix(godeltaprof): optionally emmit generics types #70

merged 5 commits into from
Nov 24, 2023

Conversation

korniltsev
Copy link
Collaborator

@korniltsev korniltsev commented Nov 23, 2023 •
edited
Loading

#69

@korniltsev korniltsev changed the title WIP fix: optionally emmit generics types WIP fix(godeltaprof): optionally emmit generics types Nov 24, 2023
@korniltsev korniltsev force-pushed the generics-fix branch 2 times, most recently from fa64253 to f0d512a Compare November 24, 2023 03:23
@korniltsev korniltsev marked this pull request as ready for review November 24, 2023 03:27
@korniltsev korniltsev changed the title WIP fix(godeltaprof): optionally emmit generics types fix(godeltaprof): optionally emmit generics types Nov 24, 2023
kolesnikovae
kolesnikovae approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@kolesnikovae kolesnikovae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I would only consider enabling this by default just to match the builtin profiler behaviour

@korniltsev
Copy link
Collaborator Author

Oh, I made it disabled by default to not change behavior of existing users, but Im fine enabling it by default

@korniltsev korniltsev merged commit 2c4a629 into main Nov 24, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolesnikovae kolesnikovae kolesnikovae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@korniltsev @kolesnikovae