Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add commitlint config #488

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: add commitlint config #488

wants to merge 3 commits into from
+733 −17

Conversation

adamyeats
Copy link
Collaborator

This PR experiments with adding git commit hooks with husky/lint-staged, and standardised commit messages with @commitlint/cli/@commitlint/config-conventional. The goal is to eventually generate a changelog using these commit messages.

@adamyeats adamyeats added effort/small datasource/SurrealDB dependencies Pull requests that update a dependency file type/chore labels Nov 27, 2024
@adamyeats adamyeats self-assigned this Nov 27, 2024
@adamyeats adamyeats requested a review from a team as a code owner November 27, 2024 16:32
aangelisc
aangelisc previously approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@aangelisc aangelisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would love to see this become a consistent thing across our repos

aangelisc
aangelisc approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@aangelisc aangelisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we perhaps add a comment if it fails just to streamline the fixing of this? Not a requirement by any means though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aangelisc aangelisc aangelisc approved these changes

@bossinc bossinc Awaiting requested review from bossinc bossinc is a code owner automatically assigned from grafana/partner-datasources

@katebrenner katebrenner Awaiting requested review from katebrenner katebrenner is a code owner automatically assigned from grafana/partner-datasources

@alyssabull alyssabull Awaiting requested review from alyssabull alyssabull is a code owner automatically assigned from grafana/partner-datasources

Assignees

@adamyeats adamyeats

Labels
datasource/SurrealDB dependencies Pull requests that update a dependency file effort/small type/chore
Projects
Partner Datasources
Status: Incoming
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamyeats @aangelisc