Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: OneOf Input Objects #825

Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open

RFC: OneOf Input Objects #825

wants to merge 36 commits into from
+197 −2

Commits on Feb 19, 2021

  1. Renumber list items

    @benjie
    benjie committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    c385058 View commit details
    Browse the repository at this point in the history

  2. @OneOf input objects

    @benjie
    benjie committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    f6bd659 View commit details
    Browse the repository at this point in the history

  3. @OneOf fields

    @benjie
    benjie committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    39e593c View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2021

  1. Fix typos (thanks @eapache!)

    @benjie
    benjie committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    b6741c3 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2021

  1. Much stricter validation for oneof literals (with examples)

    @benjie
    benjie committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    d17d5ec View commit details
    Browse the repository at this point in the history

  2. Add missing coercion rule

    @benjie
    benjie committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    dca3826 View commit details
    Browse the repository at this point in the history

  3. Clearer wording of oneof coercion rule

    @benjie
    benjie committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    7e02f5a View commit details
    Browse the repository at this point in the history

  4. Add more examples for clarity

    @benjie
    benjie committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    4111476 View commit details
    Browse the repository at this point in the history

  5. Rename introspection fields to oneOf

    @benjie
    benjie committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    6754e0a View commit details
    Browse the repository at this point in the history

  6. Oneof's now require exactly one field/argument, and non-nullable vari… 

    …ables.
    @benjie
    benjie committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    7c4c1a2 View commit details
    Browse the repository at this point in the history

  7. Remove extraneous newline

    @benjie
    benjie committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    bb225f7 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2021

  1. graphgl -> graphql

    @benjie
    benjie committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    05fde06 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from @eapache's review

    @benjie
    benjie authored Apr 8, 2021
    Configuration menu
    Copy the full SHA
    e8f6145 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Michael Staib <[email protected]>
    @benjie @michaelstaib
    benjie and michaelstaib authored Dec 23, 2021
    Configuration menu
    Copy the full SHA
    08abf49 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2022

  1. Update spec/Section 3 -- Type System.md

    @benjie
    benjie authored Jan 4, 2022
    Configuration menu
    Copy the full SHA
    59cb12d View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2022

  1. Merge branch 'main' into oneof-v2

    @benjie
    benjie committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    c470afb View commit details
    Browse the repository at this point in the history

  2. Remove Oneof Fields from spec

    @benjie
    benjie committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    99aa5d9 View commit details
    Browse the repository at this point in the history

  3. Oneof -> OneOf

    @benjie
    benjie committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    691087d View commit details
    Browse the repository at this point in the history

  4. Spellings

    @benjie
    benjie committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    7109dbc View commit details
    Browse the repository at this point in the history

Commits on May 6, 2022

  1. Remove out of date example

    @benjie
    benjie committed May 6, 2022
    Configuration menu
    Copy the full SHA
    05ab541 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2022

  1. Rename __Type.oneOf to __Type.isOneOf

    @benjie
    benjie committed May 25, 2022
    Configuration menu
    Copy the full SHA
    6a6be52 View commit details
    Browse the repository at this point in the history

  2. Add a:null example

    @benjie
    benjie committed May 25, 2022
    Configuration menu
    Copy the full SHA
    de87d2f View commit details
    Browse the repository at this point in the history

  3. Rewrite to avoid ambiguity of language

    @benjie
    benjie committed May 25, 2022
    Configuration menu
    Copy the full SHA
    57e2388 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2022

  1. Forbid 'extend input' from introducing the @OneOf directive

    @benjie
    benjie committed May 26, 2022
    Configuration menu
    Copy the full SHA
    5a966f2 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Merge branch 'main' into oneof-v2

    @benjie
    benjie committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    e78d2b5 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Merge branch 'main' into oneof-v2

    @benjie
    benjie committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    c6cd857 View commit details
    Browse the repository at this point in the history

  2. Add yet more examples to the example coercion table

    @benjie
    benjie committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    d106233 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Indicate @oneOf is a built-in directive 

    Co-authored-by: Shane Krueger <[email protected]>
    @benjie @Shane32
    benjie and Shane32 authored Jun 4, 2024
    Configuration menu
    Copy the full SHA
    87d0b22 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Update spec/Section 3 -- Type System.md

    @benjie
    benjie authored Jun 5, 2024
    Configuration menu
    Copy the full SHA
    d88d62a View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Merge branch 'main' into oneof-v2

    @benjie
    benjie authored Jul 19, 2024
    Configuration menu
    Copy the full SHA
    a810aef View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2024

  1. remove OneOf-specific rule in favor of update to VariablesInAllowedPo… 

    …sitions

for simplicity, this PR retains the same problems for variables with defaults that are fixed by strict All Variable Usages Are Allowed
    @yaacovCR
    yaacovCR committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    a1563a9 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Clarify IsNonNullPosition algorithm

    @benjie
    benjie committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    b45c0e4 View commit details
    Browse the repository at this point in the history

  2. Clarify OneOf examples

    @benjie
    benjie committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    0c9830e View commit details
    Browse the repository at this point in the history

  3. Add more examples

    @benjie
    benjie committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    c4d0b50 View commit details
    Browse the repository at this point in the history

  4. Remove new validation rule in favour of updates to existing rules

    @benjie
    benjie authored Oct 17, 2024
    Configuration menu
    Copy the full SHA
    340594e View commit details
    Browse the repository at this point in the history

  5. Null literal is separate

    @benjie
    benjie committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    dbccf84 View commit details
    Browse the repository at this point in the history