Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump playwright/python from 1.35.0-jammy to v1.39.0-jammy in /docker/auxiliary-containers/gcb_playwright #513

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 23, 2023

Bumps playwright/python from 1.35.0-jammy to v1.39.0-jammy.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps playwright/python from 1.35.0-jammy to v1.39.0-jammy.

---
updated-dependencies:
- dependency-name: playwright/python
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file docker Pull requests that update Docker code labels Oct 23, 2023
@dependabot dependabot bot requested a review from dan-mm October 23, 2023 07:12
@github-actions
Copy link

Eco-CI Output:

Label 🖥 avg. CPU utilization [%] 🔋 Total Energy [Joules] 🔌 avg. Power [Watts] Duration [Seconds]
Total Run 18.0172 2007.8 2.87239 707
Measurement #1 18.1377 2007.8 2.87239 701

📈 Energy graph:

 
 6.51 ┤                                                                  ╭╮     ╭───╮               ╭╮    ╭──╮╭─╮
 6.06 ┤        ╭╮╭╮╭╮                              ╭╮                    ││     │   ╰──╮╭─╮╭─╮    ╭─╯╰──╮ │  ╰╯ │             ╭╮
 5.61 ┤        │╰╯╰╯│       ╭╮                     ││                  ╭╮│╰╮    │      ╰╯ ╰╯ │   ╭╯     │ │     │        ╭╮ ╭╮││                                                                                                                                                                                                        ╭╮                                                                                                          ╭╮                          ╭╮                           ╭╮
 5.16 ┤       ╭╯    ╰╮     ╭╯╰╮       ╭─╮         ╭╯│              ╭─╮ │││ │    │            │   │      │ │     │        ││ ││││                                                                            ╭╮                       ╭╮                                                                       ╭╮          ╭╮            ││                         ╭╮                                                  ╭╮                           ││                          ││                           ││                                                                                                                                                                         ╭╮                            ╭╮
 4.71 ┤     ╭─╯      ╰─────╯  ╰──────╮│ ╰─────────╯ ╰───╮╭─────────╯ │ │││ │  ╭╮│            │   │      │ │     │        ││ ││││                       ╭╮ ╭─╮          ╭╮          ╭╮           ╭╮          ││           ╭╮          ││                       ╭╮           ╭╮         ╭╮                      ││          ││           ╭╯│                         ││                       ╭──╮                   ╭╮ ╭╯╰╮          ╭╮             ╭╯│                      ╭╮ ╭╯╰╮                          ││                      ╭╮ ╭╮                      ╭╮                                  ╭─╮           ╭╮                                                                   ╭╯╰──╮                         ││
 4.26 ┤     │                        ╰╯                 ││           │ │││ ╰╮ │╰╯            │   │      ╰╮│     │       ╭╯│╭╯╰╯│             ╭╮        ││ │ ╰╮         ││          │╰╮         ╭╯╰╮         │╰╮          │╰╮         │╰╮         ╭─╮         ╭╯│         ╭─╯│         │╰╮         ╭─╮         │╰╮         │╰╮          │ │                    ╭╮ ╭─╯╰╮                   ╭╮ │  │                   ││ │  ╰╮         ││          ╭╮ │ ╰╮                     ││ │  │                     ╭╮ ╭─╯╰╮         ╭╮          ││ │╰╮          ╭╮         │╰─╮         ╭╮          ╭╮         │ │╭╮         ││╭╮╭╮          ╭─╮          ╭╮           ╭─╮         ╭╮            ╭╯    ╰╮         ╭╮         ╭╮ ╭╯│
 3.81 ┤    ╭╯                                           ╰╯           │ │││  ╰╮│              │╭╮ │       ╰╯     │       │ ╰╯   │          ╭╮ ││        ││ │  │         │╰╮         │ │         │  │         │ │         ╭╯ │         │ │         │ │         │ │         │  │         │ │         │ │         │ │         │ │          │ ╰╮         ╭╮        │╰╮│   │                   ││ │  │                   ││ │   │         ││╭╮        ││ │  │         ╭─╮         ││ │  │         ╭─╮         ││ │   │         ││╭╮        ││ │ ╰╮         ││         │  │         ││         ╭╯│         │ │││         ││││││          │ ╰╮        ╭╯│           │ │         │╰╮           │      │         ││         ││ │ ╰╮
 3.36 ┤    │                                                         │ │╰╯   ││              │││ │              │       │      ╰╮         │╰╮││        ││ │  │         │ │         │ │         │  │         │ ╰╮        │  │         │ │         │ │         │ │         │  │         │ │         │ │         │ │         │ ╰╮        ╭╯  ╰╮        ││        │ ││   │         ╭╮       ╭╯│ │  ╰╮        ╭╮        ││ │   │        ╭╯│││        ││ │  ╰╮        │ ╰╮        ││ │  ╰╮        │ ╰╮        ││ │   │        ╭╯╰╯│        ││ │  │         ││         │  │         │╰╮        │ │         │ │││        ╭╯╰╯│││          │  │        │ │           │ ╰╮        │ ╰╮          │      │        ╭╯│         ││ │  │
 2.91 ┤    │                                                         │ │     ╰╯              ╰╯│ │              ╰╮      │       │       ╭─╯ │││       ╭╯│ │  │      ╭╮╭╯ │        ╭╯ ╰╮        │  │         │  │        │  │         │ │         │ │         │ │         │  │        ╭╯ │         │ │         │ │         │  │        │    │        ││        │ ││   │         ││       │ │╭╯   │        ││        ││ │   │       ╭╯ │││       ╭╯│ │   │       ╭╯  │        ││ │   │       ╭╯  │        │╰╮│   │        │   │        ││ │  │         ││         │  │        ╭╯ │        │ │         │ │││       ╭╯   │││        ╭╮│  │       ╭╯ ╰╮          │  │       ╭╯  │        ╭╮│      │       ╭╯ ╰╮        │╰╮│  │    ╭╮
 2.46 ┤    │                                                         │╭╯                       │╭╯               │      │       │       │   │││       │ │╭╯  │      │││  │        │   │        │  │        ╭╯  │        │  │         │ │        ╭╯ │         │ ╰╮        │  │        │  │        ╭╯ │        ╭╯ │         │  │        │    │        │╰╮       │ ││   ╰╮        ││       │ ││    │        ││        ││ │   │       │  │││    ╭╮ │ │╭╯   │       │   │        ││ │   │       │   ╰╮       │ ││   ╰╮       │   ╰╮       │╰╮│  │        ╭╯╰╮        │  │        │  │        │ │         │ ╰╯│       │    ╰╯│       ╭╯││  │       │   ╰╮       ╭╮│  │       │   │        │││      │       │   ╰╮       │ ││  │    ││
 2.01 ┼────╯                                                         ╰╯                        ╰╯                ╰──────╯       ╰───────╯   ╰╯╰───────╯ ╰╯   ╰──────╯╰╯  ╰────────╯   ╰────────╯  ╰────────╯   ╰────────╯  ╰─────────╯ ╰────────╯  ╰─────────╯  ╰────────╯  ╰────────╯  ╰────────╯  ╰────────╯  ╰─────────╯  ╰────────╯    ╰────────╯ ╰───────╯ ╰╯    ╰────────╯╰───────╯ ╰╯    ╰────────╯╰────────╯╰─╯   ╰───────╯  ╰╯╰────╯╰─╯ ╰╯    ╰───────╯   ╰────────╯╰─╯   ╰───────╯    ╰───────╯ ╰╯    ╰───────╯    ╰───────╯ ╰╯  ╰────────╯  ╰────────╯  ╰────────╯  ╰────────╯ ╰─────────╯   ╰───────╯      ╰───────╯ ╰╯  ╰───────╯    ╰───────╯╰╯  ╰───────╯   ╰────────╯╰╯      ╰───────╯    ╰───────╯ ╰╯  ╰────╯╰──
                                                                                                                                                                                                                                                                                                                                                             Watts over time

@ArneTR
Copy link
Member

ArneTR commented Oct 27, 2023

Closing this PR and hoping to see v2 online then on: https://hub.docker.com/repository/docker/greencoding/gcb_playwright/tags?page=1&ordering=last_updated

@ArneTR ArneTR merged commit 9117f73 into main Oct 27, 2023
2 checks passed
@dependabot dependabot bot deleted the dependabot/docker/docker/auxiliary-containers/gcb_playwright/main/playwright/python-v1.39.0-jammy branch October 27, 2023 07:59
@ArneTR
Copy link
Member

ArneTR commented Oct 27, 2023

direct fail ... @dan-mm ?

@dan-mm
Copy link
Contributor

dan-mm commented Oct 27, 2023

It was a permission error with the build-containers script file - Checked in a fix on main.

Now I need to figure out how to retrigger this workflow in a way that picks up both the fix and the PR changelist...

@dan-mm
Copy link
Contributor

dan-mm commented Oct 27, 2023

Ok - I've added an option to the build-containers workflow so that when its run manually, you can select which container to build

So if we ever get in the situation like this where the PR has closed but the workflow wasn't run successfully, you can still push the container after the fact. I've done so here:

Run: https://github.com/green-coding-berlin/green-metrics-tool/actions/runs/6665030792/job/18113808184
built container: https://hub.docker.com/r/greencoding/gcb_playwright/tags

@ArneTR
Copy link
Member

ArneTR commented Oct 27, 2023

I see the updated version on Github, but the docker container does not contain the expected content.

If I do:

$ docker run --rm  mcr.microsoft.com/playwright/python:v1.39.0-jammy ls ms-playwright
chromium-1084
ffmpeg-1009
firefox-1425
webkit-1921

You see that in the latest version 1.39 chromium is 1084

If I do that in your v2 container I get:

$ docker run --rm  greencoding/gcb_playwright:v2 ls ms-playwright
chromium-1067
ffmpeg-1009
firefox-1408
webkit-1860

Can you please investigate

@dan-mm
Copy link
Contributor

dan-mm commented Oct 27, 2023

Hm, I believe this is might be an error in our Dockerfile:

(after this dependabot merge):

FROM mcr.microsoft.com/playwright/python:v1.39.0-jammy

# Install dependencies
RUN apt-get update && apt-get install -y  curl  wget  gnupg  && rm -rf /var/lib/apt/lists/*

# Install Playwright
RUN pip install playwright==1.35.0

# Set up Playwright dependencies for Chromium, Firefox and Webkit
RUN playwright install
RUN playwright install-deps

CMD ["/bin/bash"]

Even though dependabot updated the FROM line to v1.39, when we run pip install that version is pinned to 1.35. Then in the output of the build workflow:

#9 [linux/amd64 4/5] RUN playwright install
#9 0.424 Removing unused browser at /ms-playwright/chromium-1084
#9 0.425 Removing unused browser at /ms-playwright/firefox-1425
#9 0.425 Removing unused browser at /ms-playwright/webkit-1921
#9 0.458 Downloading Chromium 115.0.5790.24 (playwright build v1067) from https://playwright.azureedge.net/builds/chromium/1067/chromium-linux.zip

checking playwrights documentation, the chromium version has changed between these two versions.

So I think the right thing to do here is just not pin the version in the RUN pip install playwright line - I don't see a reason for it to be pinned. Am I missing anything or can I go ahead and do that?

@ArneTR
Copy link
Member

ArneTR commented Oct 31, 2023

seems to fix it in my version. Have applied the fix and now rebuilding container

ArneTR added a commit that referenced this pull request Nov 10, 2023
* main: (110 commits)
  Adding report url instead of just ID (#531)
  Makes error optional except if there is data we need (#530)
  Bump uvicorn[standard] from 0.23.2 to 0.24.0.post1 (#526)
  Adding current clocksource in linux according to timing problems outlined here: https://www.brendangregg.com/blog/2021-09-26/the-speed-of-time.html (#524)
  Bump orjson from 3.9.9 to 3.9.10 (#519)
  Bump pandas from 2.1.1 to 2.1.2 (#520)
  Update Dockerfile - Removed playwright version pinning (#523)
  Bump fastapi from 0.104.0 to 0.104.1 (#522)
  Casts everything to bigint in hog api
  Qol Updates (#521)
  build containers workflow: removed conditional from job scope and moved to step
  added options for build containers manual run to specify which container to build
  fix file permissions  for build-containers script
  Bump playwright/python in /docker/auxiliary-containers/gcb_playwright (#513)
  Bump pytest from 7.4.2 to 7.4.3 (#515)
  Added lshw to hardware_info_root (#514)
  Tag dockerhub containers (#518)
  Update XGBoost model
  Update README.md
  Bump pylint from 3.0.1 to 3.0.2 (#512)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants