Refactor OverlappingFluidSolidMap #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yup. Looks like we need to bump to at least libMesh/libmesh@2a96106 for the parallel_sync. |
First step in updating the API for OverlappingFluidSolidMap. We want to hide the more complicated objects and make things easier for the user as well as make it easer to do parallel syncing of the map.
We've added new API so that we don't have to provide access to the raw underlying storage.
We never used this anyway, but we're going to refactor this data structure so we'll wipe out the interface now and modify the data structure under the hood.
This will only work in serial for the moment. Parallel syncing will happen in subsequent commits.
This will pack up the information we need to send to other processors in order to sync up the overlapping map.
Packs up solid and fluid element ids to send and then calls libMesh::Parallel::push_parallel_vector_data to send the data. The extraction functor populates both the map-to-set data structures since we have the data to fill both.
Add capability to query to make sure there are overlapping fluid elements on a given solid element, or vice-versa.
pbauman
force-pushed
the
refactor-overlapping-map
branch
from
c1b3585 to
3acdce0
Compare
|
Rebased on master. Will merge if these tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the API to be more user friendly and avoid gross data types. Also now fixed the lack of parallel syncing which was ultimately an issue downstream for getting a
GhostingFunctorto work correctly. This useslibMesh::Parallel::push_parallel_vector_data, which now uses the NBX (non-blocking consensus) algorithm. We'll see if the older libMesh used the same API before this was updated on the libMesh side. If not, then we'll bump the minimum libMesh version (which we're going to do for GMG anyway). ATM, we don't have any unit testing of the parallel_sync (see #575).