Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ringhash: make endpoint hash key configurable, and set it from EDS #7161

Closed

Conversation

atollena
Copy link
Collaborator

@atollena atollena commented Apr 23, 2024

Implement part 2 of A76: the ability to specify the location of endpoints on the ring, and a default implementation based on EDS metadata that matches Envoy behavior.

RELEASE NOTES:

  • ringhash: Make endpoint hash key configurable, and set it from EDS (gRFC A76)

Implement part 2 of A76: the ability to specify the location of endpoints on the
ring, and a default implementation based on EDS metadata that matches Envoy
behavior.
@atollena atollena force-pushed the A76-hash-key-endpoint-attribute branch from 2fe5b52 to e1bf6bf Compare April 23, 2024 15:18
@atollena
Copy link
Collaborator Author

atollena commented Apr 23, 2024

Ready to review, will wait for A76 to be merged before merging this.

@atollena atollena added the Type: Feature New features or improvements in behavior label Apr 26, 2024
@atollena atollena added this to the 1.64 Release milestone Apr 26, 2024
@ginayeh ginayeh requested a review from arvindbr8 April 30, 2024 16:10
@atollena atollena marked this pull request as ready for review April 30, 2024 16:14
@arvindbr8 arvindbr8 modified the milestones: 1.64 Release, 1.65 Release May 9, 2024
@atollena
Copy link
Collaborator Author

atollena commented Jun 4, 2024

Closing until the rest of the work in this gRFC is properly implemented.

@atollena atollena closed this Jun 4, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Status: Blocked Type: Feature New features or improvements in behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants