Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s2a: Load resources from classpath instead of from disk #11702

Merged
merged 5 commits into from
Nov 27, 2024
Merged

s2a: Load resources from classpath instead of from disk #11702

merged 5 commits into from
Nov 27, 2024
+156 −117

Conversation

rmehta19
Copy link
Contributor

No description provided.

@rmehta19
Copy link
Contributor Author

@larry-safran / @ejona86 , please review? Thanks!

larry-safran
larry-safran reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@larry-safran larry-safran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you need to have the files with the specified names for the tests to load the resources?

s2a/src/test/java/io/grpc/s2a/S2AChannelCredentialsTest.java Outdated Show resolved Hide resolved
s2a/src/test/java/io/grpc/s2a/internal/handshaker/FakeS2AServerTest.java Outdated Show resolved Hide resolved
s2a/src/test/java/io/grpc/s2a/internal/handshaker/FakeWriter.java Show resolved Hide resolved
@rmehta19
Copy link
Contributor Author

Don't you need to have the files with the specified names for the tests to load the resources?
Perhaps I'm misunderstanding this comment; but the tests are loading the files they need from the resources folder. I believe since it's loading from classpath, we don't need to specify the full file path, just the name of the file. Does this address your question?

@larry-safran

@rmehta19
Copy link
Contributor Author

@larry-safran / @ejona86 , are there any additional comments to address on this PR?

@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Nov 22, 2024
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Nov 22, 2024
@ejona86 ejona86 merged commit 55cef63 into grpc:master Nov 27, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larry-safran larry-safran larry-safran approved these changes

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rmehta19 @ejona86 @larry-safran @grpc-kokoro