service config: add Random Subsetting LB Policy (gRFC A68) #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-matyukevich
commented
Jul 23, 2024
| @@ -526,6 +536,8 @@ message LoadBalancingConfig { | |||
| OutlierDetectionLoadBalancingConfig outlier_detection = 15 | |||
| [json_name = "outlier_detection_experimental"]; | |||
| RlsLoadBalancingPolicyConfig rls = 19 [json_name = "rls_experimental"]; | |||
| RandomSubsettingLbConfig random_subsetting = 21 | |||
| [json_name = "random_subsetting_experimental"]; | |||
There was a problem hiding this comment.
Should I use _experimental suffix here? If yes I may need to update gRFC.
There was a problem hiding this comment.
Those other experimental policies aren't to be used outside of grpc itself right now. Since yours is for general use, it'd go above the "REMAINING POLICIES ARE EXPERIMENTAL" section and not be experimental. Implementations should keep it _experimental until it is properly tested, but that's separate from this proto.
@dfawley, agreed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See grpc/proposal#423 for details.