Update Dockerfile to run Java 17 #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Upgrade production docker image to use Java 17 to make the build compatible with the latest diga-api-client + in the production docker image create a new user so the application is not run as root
|
@jakob-p thanks for your contribution. Your changes together with the changes from #25 are now released as version v2.0.0 https://github.com/gtuk/diga-api-service/releases/tag/v2.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest Version of the diga-api-client 2.0.0-beta.1 will break when validating or billing codes other then the test code because the dependency update of base32check-java to 0.1.0 requires Java 17.
This PR updates the production docker image to use Java 17. It uses the eclipse-temurin:17-alpine image to have a more lightweight docker image. It also adds a new user in order to avoid running the application as root.
Upgrade production docker image to use Java 17 to make the build compatible with the latest diga-api-client
in the production docker image create a new user so the application is not run as root