Allow methodologies to configure the test name #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomrf1
commented
Nov 22, 2024
| @@ -84,14 +84,6 @@ const selectVariantWithMethodology = <V extends Variant, T extends Test<V>>( | |||
| return selectVariantUsingMVT<V, T>(test, mvtId); | |||
| }; | |||
|
|
|||
| const addMethodologyToTestName = (testName: string, methodology: Methodology): string => { | |||
There was a problem hiding this comment.
no longer necessary as we can use the testName from the methodology
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous PR introduced the ability to configure more than 1 methodology per message test. E.g. AB test vs Bandit test.
If more than one methodology is configured then the the audience is split evenly between the methodologies. Each methodology is tracked separately with a different test name.
We haven't used this yet as it's not quite ready and it's not available in the RRCP tools.
This PR modifies the logic a little.
Instead of SDC having to generate a test name for each methodology, we instead add a
testNamefield to the methodology model, so that the RRCP can define the names for tracking.This test name is used in two ways: