Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support -strict in test arguments #10039

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Support -strict in test arguments #10039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f6d6ba
Support -strict in test arguments
niloc132 Nov 8, 2024
fd7f88d
Revert adding -strict to all user tests
niloc132 Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions user/src/com/google/gwt/junit/JUnitShell.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
import com.google.gwt.dev.util.arg.ArgHandlerScriptStyle;
import com.google.gwt.dev.util.arg.ArgHandlerSetProperties;
import com.google.gwt.dev.util.arg.ArgHandlerSourceLevel;
import com.google.gwt.dev.util.arg.ArgHandlerStrict;
import com.google.gwt.dev.util.arg.ArgHandlerWarDir;
import com.google.gwt.dev.util.arg.ArgHandlerWorkDirOptional;
import com.google.gwt.junit.JUnitMessageQueue.ClientStatus;
Expand Down Expand Up @@ -299,6 +300,7 @@ public int handle(String[] args, int tagIndex) {
registerHandler(new ArgHandlerFilterJsInteropExports(options));
registerHandler(new ArgHandlerSetProperties(options));
registerHandler(new ArgHandlerClosureFormattedOutput(options));
registerHandler(new ArgHandlerStrict(options));

/*
* ----- Options specific to JUnitShell -----
Expand Down
2 changes: 1 addition & 1 deletion user/test/com/google/gwt/junit/JUnitShellTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public void testDefaultModuleUrl() throws Exception {
public void testArgOptimize() throws Exception {
parseGoodArgs("-optimize", "8", "-XdisableInlineLiteralParameters",
"-XdisableRemoveDuplicateFunctions", "-XdisableClusterSimilarFunctions",
"-XdisableOrdinalizeEnums", "-XdisableOptimizeDataflow");
"-XdisableOrdinalizeEnums", "-XdisableOptimizeDataflow", "-strict");
}

private void parseGoodArgs(String... argsToUse) {
Expand Down