fix config handling revert complex patch handling #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaggacao
force-pushed
the
fix-config-handling-revert-complex-patch-handling
branch
from
a1e8206
to
48e2161
Compare
In more advanced usage scenarios, the guarantees of this code path are never strong enough and the error produced is non-recoverable. Sorry to lovers of "automagic".
The patching functionality is fundamentally ill designed and makes the code complex to the point that it is increasingly hard to audit it for correctness. The root of evil and ill-design is that it is a work-around for what the Unoficial Flake Roadmap describes as follows: - flake inputs are flake inputs - patched flake inputs are flake inputs Furthermore this commit fixes a naive implementation of nixpkgs.config handling that causes nasty regressions on edge cases. Namely, not only can a nixpkgs config be a function, but also the merging semantics as defined by the module system requires detailed knowledge of the potential shape of the cofig attrs / function.
blaggacao
force-pushed
the
fix-config-handling-revert-complex-patch-handling
branch
from
48e2161
to
ed14e98
Compare
|
I agree with this, but I realize a fair bit of contributors to here really value the patches feature. I think we need some discussion on patching and what people use it for. |
shism2
approved these changes
Jun 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert patching functionality and fix config handling
The patching functionality is fundamentally ill designed
and makes the code complex to the point that it is increasingly
hard to audit it for correctness.
The root of evil and ill-design is that it is a work-around for
what the Unoficial Flake Roadmap describes as follows:
Furthermore this commit fixes a naive implementation of nixpkgs.config
handling that causes nasty regressions on edge cases. Namely, not only
can a nixpkgs config be a function, but also the merging semantics
as defined by the module system requires detailed knowledge of the
potential shape of the cofig attrs / function.