Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat-630 - Redesign of Date Range Picker #651

Merged

Conversation

gibsonliketheguitar
Copy link
Member

@gibsonliketheguitar gibsonliketheguitar commented Apr 1, 2024

Description

Redesign Implementation of calendar month.

  • Calendar app code was cannibalize and 2 month calendar was created along with utility functions
  • Added suggestion tab to allow user to select presets

Notes

  • Might have read instruction wrong, but I can make changes to relative preset fairly easily

Related Issues

Resolves #630

Testing

  • Ran testing suites.
  Date Range 2 month Calendar
    ✓ renders Back Arrow Icon (45 ms)
    ✓ renders Forward Arrow Icon (9 ms)
    ✓ renders current month and next month (14 ms)
    ✓ render current month's year and next month's year (13 ms)
  Date Range Call to Action 
    ✓ renders current month and next month (19 ms)
    ✓ render December 2024 and January 2025 when Forward Arrow is pressed (224 ms)
    ✓ render October 2024 and November 2024 when Forward Arrow is pressed (52 ms)
    
    Date Range Suggestions Radio Group
    ✓ renders radio group and all it's options (17 ms)

Checklist

  • I have followed all conventions outlined in our documentation.
  • I have fully tested my changes and confirmed that all new and existing tests pass.
  • I have written meaningful commit messages for all changes.
  • I have linted and formatted my changes to follow the code style of this repository.
  • I have updated our documentation, accordingly.
  • I have checked currently opened pull requests to ensure that there are no pending pull request for the same changes or issues.
  • I have confirmed that this pull request fully meets the acceptance criteria for all related issues listed above.

Copy link

netlify bot commented Apr 1, 2024

Deploy Preview for luckyparking ready!

Name Link
🔨 Latest commit 02a0231
🔍 Latest deploy log https://app.netlify.com/sites/luckyparking/deploys/6614770bf189d50008e52273
😎 Deploy Preview https://deploy-preview-651--luckyparking.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@glenflorendo glenflorendo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid work. There are just a few things to fix, then it should be all ready to merge!

@gibsonliketheguitar
Copy link
Member Author

Feeling nervous about the force push. Should I roll it back?

@gibsonliketheguitar gibsonliketheguitar merged commit 5e23e69 into hackforla:main Apr 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Frontend] Redesign date range picker
2 participants