Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Hanami 2.2.1, --env shows up twice for generate commands.
This is due to
klass.prepend(Environment)
being run twice whenever we subclassApp::Command
(like we do forApp::Generate::Command
)This change fixes that...
but it breaks our specs for the feature that automatically runs db commands intest
env when running them for development, from #247I think it's because the prepending the Environment module several times ensures it's at the top of the ancestors list.For
hanami db migrate
failure:You can see
Environment
is duplicated there, and at the start of the list.UPDATE I solved this at the point of adding the option rather than including the module and CI passes now, and only one --env option shows up, so the double prepare doesn't appear to cause any problems.