Use a clearer name for request spec shared context

“Hanami app” was too generic. By using “Rack::Test” here, we make it clearer that this shared context is specific for Rack::Test specs only.
hanami · Nov 6, 2023 · 9727983 · 9727983
1 parent 53e65ae
commit 9727983
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/lib/hanami/rspec/generators/support_requests.rb b/lib/hanami/rspec/generators/support_requests.rb
@@ -2,11 +2,12 @@
 
 require "rack/test"
 
-RSpec.shared_context "Hanami app" do
+RSpec.shared_context "Rack::Test" do
+  # Define the app for Rack::Test requests
   let(:app) { Hanami.app }
 end
 
 RSpec.configure do |config|
   config.include Rack::Test::Methods, type: :request
-  config.include_context "Hanami app", type: :request
+  config.include_context "Rack::Test", type: :request
 end
diff --git a/spec/unit/hanami/rspec/commands/install_spec.rb b/spec/unit/hanami/rspec/commands/install_spec.rb
@@ -129,13 +129,14 @@
 
         require "rack/test"
 
-        RSpec.shared_context "Hanami app" do
+        RSpec.shared_context "Rack::Test" do
+          # Define the app for Rack::Test requests
           let(:app) { Hanami.app }
         end
 
         RSpec.configure do |config|
           config.include Rack::Test::Methods, type: :request
-          config.include_context "Hanami app", type: :request
+          config.include_context "Rack::Test", type: :request
         end
       EOF
       expect(fs.read("spec/support/requests.rb")).to eq(support_requests)