Skip generating tests with --skip-tests flag given #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having the ability to skip tests when generating an action or part is useful if you know you're going to test it in _some other way_ than what we generate by default. For example, when working on a web app, and when using Capybara-driven feature specs, we generally don't want request specs generated for each action class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the ability to skip tests when generating an action or part is useful if you know you're going to test it in some other way than what we generate by default.
For example, when working on a web app, and when using Capybara-driven feature specs, we generally don't want request specs generated for each action class.
Making this change allows us to have the user run through our "building a web app" getting started guide without generating a bunch of request specs that will clutter up their new app and start failing as they change the app according to the guide.
See hanami/cli#126 for where we add the
--skip-testsflag to the CLI commands in the first place.