option for preventing DB connections leaks #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main.c
Outdated
| @@ -253,9 +257,20 @@ main_loop() | |||
| pass_through_filter(TAG_OUTPUT,""); /* If something is wrong with filter, get the error NOW */ | |||
| set_echo(FALSE); /* This will also put the terminal in CBREAK mode */ | |||
| test_main(); | |||
|
|
|||
| gettimeofday(&start_time, NULL); | |||
There was a problem hiding this comment.
Consider using clock_gettime(CLOCK_MONOTONIC) instead gettimeofday. Using gettimeofday can result in erratic behavior if NTP decides to adjust the system clock, for example.
There was a problem hiding this comment.
Right, thanks !
I was tempted to use CLOCK_MONOTONIC_RAW, but it's Linux specific
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Here is a small contribution that silently closes program after a given timeout (sec) has been provided as option.
This is really useful dealing with long sqlplus sessions on Oracle DB that are overloaded.
Hope that helps!
Thanks,
Charles