Prevent RejectedExecutionException in async mode #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed after being detached from the window. This happens on some devices when the back button is used. The fix is to null it out so that a new underlying shadowGenerator is created (with a fresh thread pool that hasn't been shutdown).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this excellent library! I've noticed on some devices that use of the back button results in a RejectedExceutionException. It appears that the onDetachedFromWindow method is invoked which releases resources for the underlying shadowGenerator. The shadowGenerator shuts down its thread pool. If this wrapper is reused afterwards in async mode, a crash occurs when tasks are submitted to this thread pool. A simple fix seems to be simply nulling out this underlying shadowGenerator so that a new one will be constructed if needed.