Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sec: suppress osv alert in CRT #24701

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

dduzgun-security
Copy link
Collaborator

Description

Ref: Thread 🧵

Testing & Reproduction steps

CRT should pass.

Links

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad website documentation to reflect this. Refer to
    the website README for docs guidelines. Please also consider whether the
    change requires notes within the upgrade guide.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.

@dduzgun-security dduzgun-security added theme/security theme/ci backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/1.9.x backport to 1.9.x release line labels Dec 17, 2024
@dduzgun-security dduzgun-security self-assigned this Dec 17, 2024
@dduzgun-security dduzgun-security requested review from a team as code owners December 17, 2024 19:38
@dduzgun-security dduzgun-security changed the title Sec/suppress go 2022 0635 OSV alert sec: suppress osv alert in CRT Dec 17, 2024
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Summarizing the linked thread for posterity: this vulnerability doesn't actually impact Nomad. The SDK is going to be a good-sized lift to update, as it's also a transitive dependency of go-kms-wrapping, go-discover, and go-getter. This will unblock the release in the meantime.

@dduzgun-security dduzgun-security merged commit a4ac202 into main Dec 17, 2024
41 checks passed
@dduzgun-security dduzgun-security deleted the sec/suppress-GO-2022-0635-osv-alert branch December 17, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/1.9.x backport to 1.9.x release line theme/ci theme/security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants