Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove case transformation in normalizeOutputKey #537

Closed

Conversation

martinsolberg
Copy link

Description

Removes case transformation in normalizeOutputKey. Will allow keys to be exported as environment variables with case intact when using wildcard lookup.

Closes #536

Checklist

  • Added CHANGELOG entry (only for user-facing changes)

Community Note

  • Please vote on this pull request by adding a 👍
    reaction
    to the original pull request comment to help the community and maintainers
    prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request
    followers and do not help prioritize the request

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 20, 2024

CLA assistant check
All committers have signed the CLA.

@fairclothjm
Copy link
Contributor

@martinsolberg Hi, I am sorry you are having trouble here. I think this use case makes sense. However, I think this may be a breaking change. (I haven't tested it or run the acceptance tests yet). How will this change affect the existing behavior of normalizing the selector key: https://github.com/hashicorp/vault-action?tab=readme-ov-file#simple-key?

@martinsolberg
Copy link
Author

@fairclothjm That may very well be the case, I do not have sufficient insight to make a judgement on that. If this change introduces some unfortunate consequences, someone else will have to have a go at it.

@martinsolberg
Copy link
Author

Use #545 to resolve this issue instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Key transformed to uppercase when exported to env var using wildcard
4 participants