Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to sequelize v4 #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

davidvanleeuwen
Copy link

@hauru
Copy link
Owner

hauru commented Jun 19, 2017

Thanks. Will be resolving this shortly. I'd like to get the update smoothed out so as the module could still be used with Sequelize 3.x.

@davidvanleeuwen
Copy link
Author

davidvanleeuwen commented Jun 19, 2017

@hauru True. The easiest way for people to keep on working would be doing a version bump to e.g. to 1.0.0 (as most people install packages with ^, and therefor people will have to specify this new version for v4) or the other way around were we explicitly say this in the readme that this is now for v4 and you should use 0.10.2 if you're not on v4. What do you think?

@hauru
Copy link
Owner

hauru commented Jun 19, 2017

@davidvanleeuwen Actually the changes are not overly dramatic from our point of view and both versions of Sequelize can be easily supported along each other. I've created a separate branch for the time being. This has yet to be tested with Sequelize 4. Also there are other minor changes that i may need to take into account, like those related to data types.

@yelled3
Copy link

yelled3 commented Jun 26, 2017

LGTM

@hauru
Copy link
Owner

hauru commented Jun 26, 2017

Changes from the aforementioned branch are now in master and in NPM. @davidvanleeuwen thanks for your input! Although I didn't do a merge, your edits were helpful.

@davesag
Copy link

davesag commented May 9, 2018

You might want to close this PR given you've incorporated its main features already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants