Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(RouteDiagram): Show total exchanges instead of completed #1181

Merged
merged 2 commits into from
Oct 23, 2024
Merged

fix(RouteDiagram): Show total exchanges instead of completed #1181

merged 2 commits into from
Oct 23, 2024

Conversation

mmelko
Copy link
Collaborator

@mmelko mmelko commented Oct 22, 2024 •
edited
Loading

closes: #535

Now the routeDiagram shows correct number of messages while routes being debugged:
Screenshot 2024-10-22 at 17 14 19

Also the route diagram for the single route now displays the inflight count:
Screenshot 2024-10-22 at 18 23 48

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 22, 2024 •
edited
Loading

Test Results

  8 files  ±0    8 suites  ±0   46m 33s ⏱️ -13s
 66 tests ±0   64 ✅ ±0   2 💤 ±0  0 ❌ ±0 
536 runs  ±0  508 ✅ ±0  28 💤 ±0  0 ❌ ±0 

Results for commit 730620e. ± Comparison against base commit 1ca2037.

♻️ This comment has been updated with latest results.

@hawtio-ci
Copy link

hawtio-ci bot commented Oct 22, 2024 •
edited
Loading

Test results

Run attempt: 2585
Detailed summary

NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
test-results-quarkus-node(18)-java(17)-firefox 67 64 3 0 0 346.453
test-results-quarkus-node(18)-java(21)-firefox 67 64 3 0 0 347.861
test-results-quarkus-node(20)-java(17)-firefox 67 64 3 0 0 353.455
test-results-quarkus-node(20)-java(21)-firefox 67 64 3 0 0 348.55
test-results-springboot-node(18)-java(17)-firefox 67 63 4 0 0 348.977
test-results-springboot-node(18)-java(21)-firefox 67 63 4 0 0 348.15
test-results-springboot-node(20)-java(17)-firefox 67 63 4 0 0 351.641
test-results-springboot-node(20)-java(21)-firefox 67 63 4 0 0 348.125

@mmelko mmelko changed the title fix(#303): Show total exchanges instead of completed fix(RouteDiagram): Show total exchanges instead of completed Oct 22, 2024
tadayosi
tadayosi approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment.

@tadayosi
Copy link
Member

@mmelko Also don't forget to backport this to 1.6.x once merged. Otherwise your fix won't be applied to the product.

@mmelko
fix(routes-service): Fetch always statistics from the context, becaus…
730620e 
…e the stats from the route don't inlcude inflights
@mmelko mmelko merged commit 66d126e into hawtio:main Oct 23, 2024
13 checks passed
@mmelko mmelko mentioned this pull request Oct 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadayosi tadayosi tadayosi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Camel Route Debug - breakpoint doesn't hold a route
2 participants
@mmelko @tadayosi