Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core,ui,app): implement plugin mechanism based on module federation #213

Merged
merged 5 commits into from
Mar 31, 2023

Conversation

tadayosi
Copy link
Member

Relates #32

This completes the implementation of the new plugin mechanism based on module federation. This works well in development mode, but I observe a plugin loading issue at the main Hawtio project. I'll keep it on hold until I'm sure it's resolvable at the main Hawtio project side before merging.

Copy link
Member

@phantomjinx phantomjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Couple of follow-on considerations for us to think about.

packages/hawtio/src/core/event-service.ts Show resolved Hide resolved
Copy link
Contributor

@joshiraez joshiraez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

While it is unrelated to the issue of 'Conflicting order' in CSS
building, this seems to solve the CSS chunking issue with the main
Hawtio project downstream. Here we sync configuration between the app
in hawtio-next and the console in hawtio downstream.
@tadayosi tadayosi force-pushed the issue-32-load-external-plugins branch from 55ddd5d to 9276c60 Compare March 30, 2023 13:27
@tadayosi tadayosi merged commit 3a41c62 into hawtio:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants