Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Support newer Android version and AGP >=8.0.0 compatibility #113

Merged
merged 2 commits into from
Nov 17, 2024

Conversation

PikPakPik
Copy link
Contributor

@PikPakPik PikPakPik commented Aug 21, 2024

AGP >= 8 need to specify a namespace (#104)
We need to update the compileSdk version due to this error "resource android:attr/lStar not found" since Android 12 so update to support 14 and lower (#112)

@PikPakPik PikPakPik changed the title [FIX] Bump compileSdk version and AGP >8.0.0 compatibility [FIX] Support newer Android version and AGP >=8.0.0 compatibility Aug 21, 2024
@zigapovhe
Copy link

@hemanthrajv Can this be merged please?
@PikPakPik Thanks for your contribution!

@Lah123
Copy link

Lah123 commented Sep 10, 2024

Can somewone please merge this and make the new version available? I cannot build my project without this change. I have to reference the git project of @PikPakPik to make it work.

@LGro
Copy link

LGro commented Sep 21, 2024

It seems like transistorsoft/flutter_background_fetch/issues/376 also works here, at least after adding the following to android/build.gradle I got my project with the official flutter_compass dependency to build again:

subprojects {
    afterEvaluate { project ->
        if (project.plugins.hasPlugin("com.android.application") || project.plugins.hasPlugin("com.android.library")) {
            project.android {
                compileSdkVersion 34
                buildToolsVersion "34.0.0"
            }
        }
    }
}
subprojects {
    project.buildDir = "${rootProject.buildDir}/${project.name}"
}
subprojects {
    project.evaluationDependsOn(":app")
}

I'm not confident I understand what is happening here exactly, does this adapt the toolchain version to be different for dependencies?

@mrsrmn
Copy link

mrsrmn commented Sep 23, 2024

when will this be merged? this is extremely important, i cant build my project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants