Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build sea for windows macos and linux #59

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Conversation

Brocco
Copy link
Contributor

@Brocco Brocco commented Jun 13, 2024

No description provided.

@Brocco Brocco force-pushed the sea-other-os branch 18 times, most recently from 2b4dfdb to 2e547dc Compare June 17, 2024 19:23
@Brocco Brocco marked this pull request as ready for review June 17, 2024 19:58
Copy link

@aavorthmann aavorthmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor question

on:
workflow_call:
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we name this token for what it is so we can find it ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an org token, for making requests to github. It's used in many places/repos
This being a herodevs repo, I don't know anything about it.

- name: upload windows zip asset
uses: actions/upload-release-asset@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question regarding naming

on:
workflow_call:
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an org token, for making requests to github. It's used in many places/repos
This being a herodevs repo, I don't know anything about it.

@Brocco Brocco merged commit 789f637 into herodevs:main Jun 18, 2024
14 checks passed
@Brocco Brocco deleted the sea-other-os branch June 18, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants