This repository has been archived by the owner on Sep 20, 2021. It is now read-only.
Set header buffer size #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Discussion happens in #73. |
Hywan
reviewed
Mar 24, 2017
Server.php
Outdated
| * | ||
| * @var int | ||
| */ | ||
| protected $headerLength = 2048; |
There was a problem hiding this comment.
As discussed in #73, remove this.
Hywan
suggested changes
Mar 24, 2017
Server.php
Outdated
| * @param int $length | ||
| * @return void | ||
| */ | ||
| public function setHeaderBufferSize($length) |
There was a problem hiding this comment.
As discussed in #73, remove this.
Server.php
Outdated
| @@ -89,7 +106,7 @@ public function __construct( | |||
| protected function doHandshake() | |||
| { | |||
| $connection = $this->getConnection(); | |||
| $buffer = $connection->read(2048); | |||
| $buffer = $connection->read($this->headerLength); | |||
There was a problem hiding this comment.
As discussed in #73, just increase to 4096.
remove setter header buffer size and hardcode 4096bytes
Pierozi
force-pushed
the
feature/bufferSize
branch
from
872eb20 to
4fd4e5d
Compare
|
ping @Hywan |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to #73
This first proposal are implement with set method.
Implement by
Zformatseems to me bit excessive for the case.We should also define as a constructor argument, but like in future we plane to make this auto detected by
Hoa\Http. Is not suitable to change the constructor interface.