-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate building wheels for common build dependencies #130709
base: dev
Are you sure you want to change the base?
Conversation
3cba1ef
to
a19a2ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means we start building wheels for packages we do not use?!?
That makes no sense to me. We will end up wasting more time as we skip releases, besides, we will put up wheels we do not use...
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
They are used:
The workflow itself takes roughly ~10min (for all jobs) when no new wheels need to be build. It's run once per day to account for PRs to the requirements file (i.e. if new once are added there). This can be remove though if we trigger a |
a19a2ab
to
cf6a850
Compare
cf6a850
to
39d245a
Compare
This change would have also helped identify an issue with a recent If it wasn't fixed upstream in time, it would have come up when we were trying to update numpy, pandas and possibly others as well. |
Proposed change
Followup to
By building wheels for common build dependencies, we can speed up the normal wheel build significantly. Without it, pip would create those wheel when installing the isolated build environments for dependencies, however those aren't cached / uploaded to wheels.home-assistant.io. Thus the wheel build would be run for each new dependency.
For full details, see description on home-assistant/wheels#807.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: