Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quality scale for Mastodon #131357

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from

Conversation

andrew-codechimp
Copy link
Contributor

Proposed change

Add quality scale for Mastodon

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @fabaff, mind taking a look at this pull request as it has been labeled with an integration (mastodon) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of mastodon can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign mastodon Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

homeassistant/components/mastodon/quality_scale.yaml Outdated Show resolved Hide resolved
homeassistant/components/mastodon/quality_scale.yaml Outdated Show resolved Hide resolved
homeassistant/components/mastodon/quality_scale.yaml Outdated Show resolved Hide resolved
homeassistant/components/mastodon/quality_scale.yaml Outdated Show resolved Hide resolved
homeassistant/components/mastodon/quality_scale.yaml Outdated Show resolved Hide resolved
homeassistant/components/mastodon/quality_scale.yaml Outdated Show resolved Hide resolved
status: done
comment: |
YAML flow deprecated and will be removed in 2025.2.0
dependency-transparency: done
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mastodon.py isn't built and published in a CI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does have reference to CircleCI passing (bottom of repo page https://github.com/halcy/Mastodon.py) so not as transparent as GitHub actions but seems to be there. Is this enough to pass?

Not making bronze because of dependency CI is tough (general observation rather than just this one).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there are only tests run on CircleCI, not the build and publishing of the package.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification, Mastodon.py is the most well supported lib out there and I don't want to build/maintain my own.

I know this is just one case but be interesting to see if this rule stops many integrations meeting bronze criteria.

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft November 26, 2024 00:26
@andrew-codechimp
Copy link
Contributor Author

Added requested changed but the dependency transparency stops it meeting bronze, but at least the quality scale shows an action list for future.

@andrew-codechimp andrew-codechimp marked this pull request as ready for review November 26, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants