-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quality scale for Mastodon #131357
base: dev
Are you sure you want to change the base?
Add quality scale for Mastodon #131357
Conversation
Hey there @fabaff, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
status: done | ||
comment: | | ||
YAML flow deprecated and will be removed in 2025.2.0 | ||
dependency-transparency: done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mastodon.py isn't built and published in a CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does have reference to CircleCI passing (bottom of repo page https://github.com/halcy/Mastodon.py) so not as transparent as GitHub actions but seems to be there. Is this enough to pass?
Not making bronze because of dependency CI is tough (general observation rather than just this one).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems there are only tests run on CircleCI, not the build and publishing of the package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification, Mastodon.py is the most well supported lib out there and I don't want to build/maintain my own.
I know this is just one case but be interesting to see if this rule stops many integrations meeting bronze criteria.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Added requested changed but the dependency transparency stops it meeting bronze, but at least the quality scale shows an action list for future. |
Proposed change
Add quality scale for Mastodon
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: