Suez water add quality_scale.yaml #131360
Conversation
|
Hey there @ooii, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
| @@ -0,0 +1,88 @@ | |||
| rules: | |||
| # Bronze | |||
| config-flow: done | |||
There was a problem hiding this comment.
The translations file also needs data_descriptions for each field
|
|
||
| # Silver | ||
| config-entry-unloading: done | ||
| log-when-unavailable: done |
There was a problem hiding this comment.
This looks like it may log more than once when unavailable given the coordinator has its own exception logging.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
jb101010-2
force-pushed
the
feat_suez-quality-scale
branch
from
a4d98f5
to
5a2f2da
Compare
| entity-event-setup: | ||
| status: exempt | ||
| comment: no subscription to api | ||
| dependency-transparency: done |
There was a problem hiding this comment.
Can you please detach the dependency repo from the original fork btw?
There was a problem hiding this comment.
I've submitted a request to Github in order to detach the fork.
There was a problem hiding this comment.
Done, fork has been detached by Github team.
jb101010-2
force-pushed
the
feat_suez-quality-scale
branch
from
f86bc0f
to
e80c12d
Compare
Proposed change
Add quality_scale.yaml to suez water integration
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: