fix JOSM remote control so url= is regular http(s) URL

[mnalis]

Otherwise, as imageryUrl is (as required) in format like tms[20]:https://tms.osm-hr.org/knin-2007/{zoom}/{x}/{-y}.png, that value would be sent as url parameter to JOSM remote control imagery load command, which would thus fail to load imagery (in current testing JOSM version 18583 at least)

This PR fixes it so url= parameter to remote control is regular http(s) URL like https://tms.osm-hr.org/knin-2007/{zoom}/{x}/{-y}.png, as it should be.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[ramyaragupathy]

hey @mnalis - can you please share more details on your Tasking Manager instance? Looks like this PR is specific for v3.

[mnalis]

Yes, that PR was made for v3, as that was what we were using (and where we had a problem) in 2022.

That specific instance (https://tasks.osm-hr.org) had since been upgraded to v4 (for other reasons, i.e. Oauth2) which (on a cursory glance) does not seem to have that problem (although I haven't done extensive testing).

[ramyaragupathy]

@mnalis - do you know of other v3 instances that we could use to test this behaviour? If none available, let's verify the behaviour in v4 and close it here

cc @royallsilwallz @manjitapandey

[mnalis]

do you know of other v3 instances that we could use to test this behaviour? If none available

As v3 only supports Oauth1, which is no longer supported by openstreetmap.org, if there are any running TM3 instances left, you wouldn't be able to log in into them any more (unless someone forked the TM3 and backported Oauth2 support into it, of course)