Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastapi refactor #6557

Closed
wants to merge 184 commits into from
Closed

Fastapi refactor #6557

wants to merge 184 commits into from

Conversation

prabinoid
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Related discussion: https://community.openstreetmap.org/t/migrating-tasking-manager-from-flask-to-fastapi-and-psycopg2-to-asyncpg/116543

Describe this PR

This PR includes the TM fastapi migration and covers the commits from the initial phases of the migration.

This PR is made only for the code review of the migration which is an ongoing process and hence the PR should NOT be merged currently.

Initially, the migration was done with sqlalchemy AsyncSession and orm but later we switched to raw sql query and encode databases to manage our async sessions and queries due to which parts of code needs cleaning and might be ambiguous too.

kaditya97 and others added 30 commits September 9, 2024 12:57
Signed-off-by: eternaltyro <[email protected]>
Signed-off-by: eternaltyro <[email protected]>
- Build multi-stage container images on specific targets - in this case
  'prod'
- Better naming for jobs

Signed-off-by: eternaltyro <[email protected]>
- Fix outputs format
- Experiment with metadata parsing in different ways
- Add labels back to container metadata

Signed-off-by: eternaltyro <[email protected]>
Signed-off-by: eternaltyro <[email protected]>
Signed-off-by: eternaltyro <[email protected]>
Signed-off-by: eternaltyro <[email protected]>
Signed-off-by: eternaltyro <[email protected]>
@ramyaragupathy ramyaragupathy added this to the FastAPI migration milestone Nov 14, 2024
Copy link

sonarcloud bot commented Nov 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
C Reliability Rating on New Code (required β‰₯ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@prabinoid prabinoid closed this Dec 2, 2024
@prabinoid prabinoid deleted the fastapi-refactor branch December 3, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants