Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update container build #463

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update container build #463

wants to merge 1 commit into from

Conversation

oscrx
Copy link

@oscrx oscrx commented May 10, 2023

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

The PR fulfills these requirements:

  • All tests are passing?
  • New/updated tests are included?
  • If any static assets have been updated, has ui/bindata.go been regenerated?
  • Are there doc blocks for functions that I updated/created?

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

I noticed the publishing of docker images needed some work in #462

These changes will fix #462 if a new version is tagged

I updated some action versions to the latest major and prevented pull requests from publishing images
Here is an example pipeline run

Here is an example of the metadata when I released version 1.3.1

  {
    "tags": [
      "ghcr.io/oscrx/hound:1.3.1",
      "ghcr.io/oscrx/hound:1",
      "ghcr.io/oscrx/hound:1.3",
      "ghcr.io/oscrx/hound:latest"
    ],
    "labels": {
      "org.opencontainers.image.title": "hound",
      "org.opencontainers.image.description": "Lightning fast code searching made easy",
      "org.opencontainers.image.url": "https://github.com/oscrx/hound",
      "org.opencontainers.image.source": "https://github.com/oscrx/hound",
      "org.opencontainers.image.version": "1.3.1",
      "org.opencontainers.image.created": "2023-05-10T10:59:14.781Z",
      "org.opencontainers.image.revision": "2f9834b4012f5d1ed133615dd0bcb98d77b67343",
      "org.opencontainers.image.licenses": "MIT"
    }
  }

And here is an example when I pushed to main:

  {
    "tags": [
      "ghcr.io/oscrx/hound:main"
    ],
    "labels": {
      "org.opencontainers.image.title": "hound",
      "org.opencontainers.image.description": "Lightning fast code searching made easy",
      "org.opencontainers.image.url": "https://github.com/oscrx/hound",
      "org.opencontainers.image.source": "https://github.com/oscrx/hound",
      "org.opencontainers.image.version": "main",
      "org.opencontainers.image.created": "2023-05-10T10:58:27.820Z",
      "org.opencontainers.image.revision": "2f9834b4012f5d1ed133615dd0bcb98d77b67343",
      "org.opencontainers.image.licenses": "MIT"
    }
  }

Please let me know if there are any questions or suggestions.

@dschott68
Copy link
Contributor

replaced by #401

@dschott68 dschott68 closed this Jun 8, 2023
@oscrx
Copy link
Author

oscrx commented Jun 8, 2023

#401 is from 2021... Are these improvements not good?

@dschott68 dschott68 reopened this Jun 8, 2023
…revent PR's from publishing

Signed-off-by: Oscar Wieman <[email protected]>
@oscrx
Copy link
Author

oscrx commented Jun 8, 2023

The build seems to succeed: https://github.com/oscrx/hound/actions/runs/5214016432/jobs/9409753133
It only tags and pushes ghcr.io/oscrx/hound:main

When I release version v4.5.6 this is the docker metadata generated and used:

  {
    "tags": [
      "ghcr.io/oscrx/hound:4.5.6",
      "ghcr.io/oscrx/hound:4",
      "ghcr.io/oscrx/hound:4.5",
      "ghcr.io/oscrx/hound:latest"
    ],
    "labels": {
      "org.opencontainers.image.title": "hound",
      "org.opencontainers.image.description": "Lightning fast code searching made easy",
      "org.opencontainers.image.url": "https://github.com/oscrx/hound",
      "org.opencontainers.image.source": "https://github.com/oscrx/hound",
      "org.opencontainers.image.version": "4.5.6",
      "org.opencontainers.image.created": "2023-06-08T17:27:45.741Z",
      "org.opencontainers.image.revision": "007937e554ae2c9f1e2d9d198840a691dfc4e25e",
      "org.opencontainers.image.licenses": "MIT"
    }
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker image currently broken (ghcr.io/hound-search/hound:latest)
2 participants