feat(config/eslint): disable class-methods-use-this rule

It makes the interface less stable. If you change a method between instance and class, you have to change all invocations. Whether or not it uses `this` is an implementation detail that should not matter for the interface Co-authored-by: Jamie Rolfs <[email protected]>
hoverinc · Apr 12, 2022 · ba848a9 · ba848a9
1 parent 4460c1f
commit ba848a9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/src/config/__tests__/__snapshots__/eslintrc.js.snap b/src/config/__tests__/__snapshots__/eslintrc.js.snap
@@ -66,6 +66,7 @@ Object {
     "@typescript-eslint/no-implied-eval": "off",
     "@typescript-eslint/no-throw-literal": "off",
     "@typescript-eslint/return-await": "off",
+    "class-methods-use-this": "off",
     "import/no-extraneous-dependencies": Array [
       "error",
       Object {
@@ -197,6 +198,7 @@ Object {
     "@typescript-eslint/no-implied-eval": "off",
     "@typescript-eslint/no-throw-literal": "off",
     "@typescript-eslint/return-await": "off",
+    "class-methods-use-this": "off",
     "import/no-extraneous-dependencies": Array [
       "error",
       Object {

diff --git a/src/config/helpers/build-eslint.js b/src/config/helpers/build-eslint.js
@@ -51,6 +51,7 @@ const buildConfig = ({withReact = false} = {}) => {
       ifReact('plugin:react-hooks/recommended'),
     ].filter(Boolean),
     rules: {
+      'class-methods-use-this': 'off',
       'import/prefer-default-export': 'off',
       'import/no-extraneous-dependencies': [
         'error',