ci: fix windows PATH env #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Metrics Report=============================================================================== Language Files Lines Code Comments Blanks =============================================================================== TOML 1 70 58 2 10 ------------------------------------------------------------------------------- Rust 66 14511 12415 201 1895 |- Markdown 35 343 0 272 71 (Total) 14854 12415 473 1966 =============================================================================== Total 67 14581 12473 203 1905 =============================================================================== |
|
🦸🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe
echo "PATH=$LIBTORCH/lib;$PATH" >> $env:GITHUB_ENVbreaks thePATHon Windows, and causesmilliewalky/setup-7-zip@v1not working (i.e. cannot findcurl). This PR fixes the issue by using the GITHUB_PATH (not GITHUB_ENV) for adding PATH.Docs: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions#adding-a-system-path