Fix check_training_gradient_checkpointing
#34806
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently inour CI runners' environment, there is no
pytest-subtests
installed. In this case, usingsubTest
withskipTest
in it will skip the whole test even if our goal is to just skip thatsubTest
and continue to the next step in the for loop. Incheck_training_gradient_checkpointing
, the firstmodel_class
is the base model and it callsskipTest
and no othermodel_class
being checked.However,
pytest-subtests
has some issues regarding the reporting. A PR is opened pytest-dev/pytest-subtests#169.In the meantime, let's use
continue
for now instead ofskipTest
so we can really test gradient checkpointing.