Expose the Accept header #162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlenDC
reviewed
Apr 25, 2024
| if parts[0].starts_with("q=") || parts[0].starts_with("Q=") { | ||
| let q_part = &parts[0][2..parts[0].len()]; | ||
| if first.starts_with("q=") || first.starts_with("Q=") { | ||
| let q_part = &first[2..]; | ||
| if q_part.len() > 5 { | ||
| return Err(::Error::invalid()); | ||
| } | ||
| match q_part.parse::<f32>() { | ||
| Ok(q_value) => { | ||
| if 0f32 <= q_value && q_value <= 1f32 { |
There was a problem hiding this comment.
Suggested change
| if 0f32 <= q_value && q_value <= 1f32 { | |
| if (0f32..=1f32).contains(&q_value) { |
GlenDC
reviewed
Apr 25, 2024
| @@ -138,7 +130,10 @@ fn from_f32(f: f32) -> Quality { | |||
| // this function is only used internally. A check that `f` is within range | |||
| // should be done before calling this method. Just in case, this | |||
| // debug_assert should catch if we were forgetful | |||
| debug_assert!(f >= 0f32 && f <= 1f32, "q value must be between 0.0 and 1.0"); | |||
| debug_assert!( | |||
| f >= 0f32 && f <= 1f32, | |||
There was a problem hiding this comment.
Suggested change
| f >= 0f32 && f <= 1f32, | |
| (0f32..=1f32).contains(&f), |
GlenDC
reviewed
Apr 25, 2024
| @@ -163,7 +167,10 @@ mod internal { | |||
|
|
|||
| impl IntoQuality for f32 { | |||
| fn into_quality(self) -> Quality { | |||
| assert!(self >= 0f32 && self <= 1f32, "float must be between 0.0 and 1.0"); | |||
| assert!( | |||
| self >= 0f32 && self <= 1f32, | |||
There was a problem hiding this comment.
Suggested change
| self >= 0f32 && self <= 1f32, | |
| (0f32..=1f32).contains(&self), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebasing #51 onto the latest
master(since the PR does not seem active).Although we also have #150, it seems not working since it does not solve the compile errors.