fix: avoid treating empty values as valid CSV input #165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using Axum, I noticed
If-Match
&If-None-Match
would always default toSome("")
making it difficult to know if the user passed the headers asIf-Match:
or not at all.I looked into the code, and it turns out the logic for consuming the values iterator defaults to an empty byte array (ergo, empty string)
I chose this peeking method and short-circuiting before calling
collect
to avoid more complex patterns.And tags in
If-Match
&If-None-Match
(depending onEntityTagRange
) weren't being validated.This fixes that.