Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual improvements for mobile (+ alt text) #38

Closed
wants to merge 3 commits into from
Closed

Visual improvements for mobile (+ alt text) #38

wants to merge 3 commits into from

Conversation

BeauTheBeau
Copy link
Contributor

Addressed a point in #32, made all buttons the same width and hid the ClipboardIcon on mobile
Also added more descriptive alt text for the distro logos ("Distrubution Logo" -> "logo of {distribution}"

@BeauTheBeau
Copy link
Contributor Author

just realised, for 3c3721c it might be better to adjust the widths when the window size drops below a specific amount, rather than relying on checking the user agent. Quick change, but i'd like to sleep so whoever sees this, haha you're it

@vaxerski
Copy link
Member

vaxerski commented Jan 1, 2024

@Visual-Dawg

@vdawg-git
Copy link
Member

Thank you for your contribution!
Yes,using media queries instead of a JS check makes more sense, I added review comments :)

@vdawg-git vdawg-git mentioned this pull request Jan 21, 2024
@vaxerski vaxerski closed this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants