Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: build zip archive in parallel and in one pass #3415

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vbfox
Copy link

@vbfox vbfox commented Oct 31, 2023

  • Use the apache compress library to zip in parallel
  • Avoid the temporary zip file and copy by adding the unknown files directly while building the apk

Notes:

* Use the apache compress library to zip in parallel
* Avoid the temporary zip file and copy by adding the unknown files
  directly while building the apk
@iBotPeaches
Copy link
Owner

We've had a pattern over the last decade of adding apache compress, ripping it back out and here we are adding it back. I do like this idea of further parallelization, but now that its merged my focus will be digging into the exact reasons we ripped out apache compress to remember if we are approaching a similar mistake.

If you are up to rebasing this to the newer parallelization model - I believe it should mostly work.

Copy link
Owner

@iBotPeaches iBotPeaches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proguard is gone now, so this has more conflicts.

@Lesia-Angarsk
Copy link

  • Use the apache compress library to zip in parallel
  • Avoid the temporary zip file and copy by adding the unknown files directly while building the apk

Notes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants