-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1779: Showing month in HeaderView calendar #1780
Issue 1779: Showing month in HeaderView calendar #1780
Conversation
Updating forked dev
The main drawback is that it takes more space, so you can visualize less habits at the same time. Maybe that's fine though? Wondering if we could have the month on the same row as the date instead. I don't have a strong opinion on this though, so fine for me. @iSoron? P.S.: for next time, if you could have screenshots in English, that'd make it easier to have an idea of what your changes do! |
Thanks for the PR, @kalina559. I'm not a huge fan of this layout as (i) it occupies more space; (ii) the month row will show the same text repeatedly, in the vast majority of situations. I agree that it would be nice to display the month sometimes, but I suggest doing what we currently do for the charts: on January 1, 2024, for example, we could show "Jan \ 1" instead of "Monday \ 1". |
Solves #1779. Not sure about this one though, it could be useful when scrolling a long way back in the Header View calendar, but it basically shows the same thing for every day of the month. Below is the comparison of the current app (1), the code in this pull request (2) and a third option that would show the month only for first/last day of the month (3). Please let me know which one makes the most sense for you.