Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'track' calls not working with empty $properties #5

Merged
merged 2 commits into from
Mar 27, 2020
Merged

Fix 'track' calls not working with empty $properties #5

merged 2 commits into from
Mar 27, 2020

Conversation

kyranb
Copy link
Contributor

@kyranb kyranb commented Mar 23, 2020

No description provided.

@kyranb
Copy link
Contributor Author

kyranb commented Mar 23, 2020

Fixes #4

mkarnicki
mkarnicki approved these changes Mar 26, 2020
View reviewed changes
Copy link

@mkarnicki mkarnicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I was about to submit the exact same change. Can we get this merged please :)?

@mkarnicki
Copy link

I'm wondering when could we expect a point release with this fix to packagist? Thanks a bunch, have a lovely day :)

@iagomelanias
Copy link
Owner

Sure, i'll merge it.

@iagomelanias
Copy link
Owner

iagomelanias commented Mar 27, 2020 •
edited
Loading

@kyranb Thank you for your contribution!

@iagomelanias iagomelanias merged commit 845adc5 into iagomelanias:master Mar 27, 2020
@github-staff github-staff deleted a comment from pisgo May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkarnicki mkarnicki mkarnicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kyranb @mkarnicki @iagomelanias