Add more details in IDNA 2008 compliance result table

icann · Sep 21, 2023 · cacc784 · cacc784
1 parent ac64cda
commit cacc784
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 17 deletions.
diff --git a/...dn_table_review/icann_tools/templates/lgr_idn_table_review_icann/idna2008_compliance.html b/...dn_table_review/icann_tools/templates/lgr_idn_table_review_icann/idna2008_compliance.html
@@ -66,23 +66,8 @@
 <div id="lgr">
     <h1>ICANN IDN Table IDNA 2008 compliance Report</h1>
     <p>IDN table: <a href="{{ idn_table_url }}">{{ idn_table }}</a></p>
-
-    <table class="simple">
-        <thead>
-        <tr>
-            <th>Code Point</th>
-            <th>IDNA property</th>
-        </tr>
-        </thead>
-        <tbody>
-        {% for data in uncompliant_cps %}
-            <tr>
-                <td>{{ data.char.cp|format_cp }}</td>
-                <td>{{ data.idna_property }}</td>
-            </tr>
-        {% endfor %}
-        </tbody>
-    </table>
+    <p>{{ uncompliant_cps|length }} code points are not IDNA 2008 compliant.</p>
+    {% include 'lgr_idn_table_review/_review_cp_report.html' with codepoints=uncompliant_cps %}
 </div>
 </body>
 </HTML>
diff --git a/src/lgr_idn_table_review/templates/lgr_idn_table_review/_review_cp_report.html b/src/lgr_idn_table_review/templates/lgr_idn_table_review/_review_cp_report.html
@@ -2,6 +2,7 @@
 
 <table class="simple">
     <tr>
+        <th>#</th>
         <th>Code<br>Point</th>
         <th>Glyph</th>
         <th>Name</th>
@@ -10,6 +11,7 @@
     </tr>
     {% for cp in codepoints %}
         <tr>
+            <td>{{ forloop.counter }}</td>
             <td>{{ cp.cp|format_cp }}</td>
             <td>{{ cp.glyph }}</td>
                     <td style="text-align:left">{{ cp.name }}</td>

diff --git a/src/lgr_tasks/tasks.py b/src/lgr_tasks/tasks.py
@@ -44,6 +44,7 @@ def clean_reports():
     ).delete()
     logger.info('%d reports removed' % nbr)
 
+
 @shared_task
 def calculate_index_variant_labels_tlds(user_pk=None):
     """