Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time zone support in schedule_from_ical #526

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Time zone support in schedule_from_ical #526

wants to merge 8 commits into from

Commits on May 3, 2022

  1. Expose time zone issue when parsing from iCal format 

    Co-authored-by: Jankees van Woezik <[email protected]>
    @epologee @jankeesvw
    epologee and jankeesvw committed May 3, 2022
    Configuration menu
    Copy the full SHA
    ee6ce49 View commit details
    Browse the repository at this point in the history

  2. Spec that from_ical and to_ical can perform round trip conversion 

    Co-authored-by: Jankees van Woezik <[email protected]>
    @epologee @jankeesvw
    epologee and jankeesvw committed May 3, 2022
    Configuration menu
    Copy the full SHA
    740125c View commit details
    Browse the repository at this point in the history

  3. Lookup the Rails time zone using the tzid (fails for many zone ids) 

    Co-authored-by: Jankees van Woezik <[email protected]>
    @epologee @jankeesvw
    epologee and jankeesvw committed May 3, 2022
    Configuration menu
    Copy the full SHA
    f1d7f6e View commit details
    Browse the repository at this point in the history

  4. Alternative time zone lookup using strftime, to complement Rails mapping 

    Co-authored-by: Jankees van Woezik <[email protected]>
    @epologee @jankeesvw
    epologee and jankeesvw committed May 3, 2022
    Configuration menu
    Copy the full SHA
    3a4ab88 View commit details
    Browse the repository at this point in the history

  5. Find the right time zone for standard times or daylight saving times 

    Using `.now` causes a search for "MST" in the winter, even if the time
of the given schedule is in summer and would only match "MDT". By
parsing the time value and using the components as values in the
candidate time zone, this issue is fixed.
    @epologee
    epologee committed May 3, 2022
    Configuration menu
    Copy the full SHA
    afa978a View commit details
    Browse the repository at this point in the history

  6. Changelog entry for PR ice-cube-ruby#526

    @epologee
    epologee committed May 3, 2022
    Configuration menu
    Copy the full SHA
    c3a7ede View commit details
    Browse the repository at this point in the history

Commits on May 5, 2022

  1. Indentation fix by standardrb

    @epologee
    epologee committed May 5, 2022
    Configuration menu
    Copy the full SHA
    c607f17 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Edit description to trigger GH actions

    @epologee
    epologee committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    e91465a View commit details
    Browse the repository at this point in the history