-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create an ab initio parse method. #595
Open
MicahGale
wants to merge
23
commits into
alpha-test-dev
Choose a base branch
from
parse_method
base: alpha-test-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicahGale
added
code improvement
A feature request that will improve the software and its maintainability, but be invisible to users.
feature request
An issue that improves the user interface.
alpha testing
Issues that came up during alpha testing
labels
Nov 22, 2024
Also an open question is: if this should ship for 0.6 or 1.0 |
To document pretty_str or not? |
MicahGale
added
parsers are hard
Examples of where MCNP syntax is complicated and should be simplified.
documentation
Improvements or additions to documentation
labels
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
alpha testing
Issues that came up during alpha testing
code improvement
A feature request that will improve the software and its maintainability, but be invisible to users.
documentation
Improvements or additions to documentation
feature request
An issue that improves the user interface.
parsers are hard
Examples of where MCNP syntax is complicated and should be simplified.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This feature adds the ability to parse MCNP inputs arbitrarily. All
MCNP_Object
now accepts and parsesstr
. This also introducesMCNP_Problem.parse
which is a convenience function that just parses, and goes. This also adds the ability to pass a number to a constructor to simplify the build.Fixes #88
Checklist