Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split postprocessor.tex into separate files #1817

Merged
merged 2 commits into from
Apr 25, 2022

Conversation

wangcj05
Copy link
Collaborator

@wangcj05 wangcj05 commented Apr 21, 2022


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

#1806

What are the significant changes in functionality due to this change request?

This PR will split the postprocessor.tex into separate files which will help developers to easily identify the sections for the individual post-processor.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@wangcj05 wangcj05 requested a review from Jimmy-INL April 21, 2022 21:40
@moosebuild
Copy link

Job Test qsubs sawtooth on 7d6b45a : invalidated by @wangcj05

Diff tests/cluster_tests/RavenRunsRaven/Code

1 similar comment
@moosebuild
Copy link

Job Test qsubs sawtooth on 7d6b45a : invalidated by @wangcj05

Diff tests/cluster_tests/RavenRunsRaven/Code

@moosebuild
Copy link

Job Test qsubs sawtooth on 7d6b45a : invalidated by @Jimmy-INL

@moosebuild
Copy link

Job Test qsubs sawtooth on 7d6b45a : invalidated by @wangcj05

Diff tests/cluster_tests/RavenRunsRaven/Code

@wangcj05
Copy link
Collaborator Author

@Jimmy-INL Tests are good for this PR. Could you merge it?

@Jimmy-INL
Copy link
Collaborator

This PR doesn't include any code changes, all changes are in the manual. In addition, there are some issues with sawtooth and the regression machines, that cause random failures that get resolved by validating the tests. But since this PR only promotes changes to the manual and these tests pass, I will go ahead and merge it.

@Jimmy-INL Jimmy-INL merged commit 75d2147 into idaholab:devel Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants