Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching windows to Python 3.10 #2197

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

joshua-cogliati-inl
Copy link
Contributor

@joshua-cogliati-inl joshua-cogliati-inl commented Oct 23, 2023


Pull Request Description

What issue does this change request address?

#1806

What are the significant changes in functionality due to this change request?

This updates the Windows Python version, because Python 3.8 was getting an error with mamba install
when switching from Python 3.11 to Python 3.8 and not being able to find truststore.

Could not solve for environment specs
The following packages are incompatible
├─ python 3.8**  is requested and can be installed;
└─ truststore is not installable because there are no viable options
   ├─ truststore [0.7.0|0.8.0] would require
   │  └─ python >=3.10  but there are no viable options
   │     ├─ python [3.11.0|3.11.1|...|3.11.6] conflicts with any installable versions previously reported;
   │     ├─ python [3.10.0|3.10.1|...|3.10.9] conflicts with any installable versions previously reported;
   │     ├─ python 3.12.0 conflicts with any installable versions previously reported;
   │     └─ python 3.12.0rc3 would require
   │        └─ _python_rc, which does not exist (perhaps a missing channel);
   ├─ truststore 0.8.0 would require
   │  └─ python >=3.10,<3.11.0a0 , which conflicts with any installable versions previously reported;
   └─ truststore 0.8.0 would require
      └─ python >=3.11,<3.12.0a0 , which conflicts with any installable versions previously reported.

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

PaulTalbot-INL
PaulTalbot-INL previously approved these changes Oct 23, 2023
Copy link
Collaborator

@PaulTalbot-INL PaulTalbot-INL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes reviewed.

@PaulTalbot-INL
Copy link
Collaborator

This can point to #1806 for library updates, but not close it.

Aside from the automated testing, this passes checklist.

PaulTalbot-INL
PaulTalbot-INL previously approved these changes Oct 24, 2023
@PaulTalbot-INL
Copy link
Collaborator

With the sawtooth qsub test machine currently unavailable, and given the limited changes in this PR, continuing with this merge despite these tests not running. Otherwise, all the tests pass, and the checklist passes.

Note that some plugin tests are failing for HERON and TEAL, but they are the same tests that were failing before this PR, so no change is introduced in those results due to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants